307-202 - sgp refresh (and.. not only this)

[psi]

Hey,
i want to show you one issue ;p in sgp_refresh.html we can find (styles/prosilver/template/sgp_refresh.html):

Code: Select all

            <div class="bg3" style="margin-right:25%;"> : {L_DISABLED} - Use refresh in ACP for time being...</div>

and should be (IMO):

Code: Select all

            <div class="bg3" style="margin-right:25%;">{L_DISABLE_USE}</div>

AND (/langauge/en/common.php):
there is:

Code: Select all

   'DISABSLE_USE'      => '<br />&nbsp;&#187;&nbsp;Disabled, use refresh in ACP for time being...',

should be:

Code: Select all

   'DISABLE_USE'      => '<br />&nbsp;&#187;&nbsp;Disabled, use refresh in ACP for time being...',

Now, the sgp_refresh is fully multilanguage file :P This is everything for today, there will be more.. I'm back
I hope that you change this Mike in 203?.

PS There is no alternatives for your portal!
PPS Is it faster than one year ago??

EDIT// You'll find more changes below

[CaNNon]

this one looks the same psi, "/langauge/en/common.php" am i missing something?
and WB!

[Prosk8er]

look how disabled is spelled

[Robster400]

He's removed the English text, and directed the script to the language file for the text, so it can be translated if needed.
Good move.

[psi]

Like said Robster

[CaNNon]

I totally missed it! Thanks guys.

[psi]

Some more improvements by psi
The "Temporarily hide blocks" function is available in the ONLY English language. How to do the translation?
In ../styles/portal_common/template/portal_head.html (4 changes)
Find:

Code: Select all

         <a href="javascript:ShowHide('left'); ShowHide('left_blocks_col_hide'); ShowHide('left_blocks_col_show');" title="Show Blocks"><img src="images/slide1.png" width="12" height="10" alt="" class="left_blocks_col_show" /></a>

Replace with:

Code: Select all

         <a href="javascript:ShowHide('left'); ShowHide('left_blocks_col_hide'); ShowHide('left_blocks_col_show');" title="{L_SHOW_BLOCKS}"><img src="images/slide1.png" width="12" height="10" alt="" class="left_blocks_col_show" /></a>

Find:

Code: Select all

         <a href="javascript:ShowHide('left'); ShowHide('left_blocks_col_show'); ShowHide('left_blocks_col_hide');" title="Temporarily Hide Blocks"><img src="images/slide2.png" width="12" height="10" alt="" class="left_blocks_col_show" /></a>

Replace with:

Code: Select all

         <a href="javascript:ShowHide('left'); ShowHide('left_blocks_col_show'); ShowHide('left_blocks_col_hide');" title="{L_HIDE_BLOCKS_TEMP}"><img src="images/slide2.png" width="12" height="10" alt="" class="left_blocks_col_show" /></a>

Find:

Code: Select all

         <a href="javascript:ShowHide('right'); ShowHide('right_blocks_col_hide'); ShowHide('right_blocks_col_show');" title="Show Blocks"><img src="images/slide2.png" width="12" height="10" alt="" class="right_blocks_col_show" /></a>

Replace with:

Code: Select all

         <a href="javascript:ShowHide('right'); ShowHide('right_blocks_col_hide'); ShowHide('right_blocks_col_show');" title="{L_SHOW_BLOCKS}"><img src="images/slide2.png" width="12" height="10" alt="" class="right_blocks_col_show" /></a>

Find:

Code: Select all

         <a href="javascript:ShowHide('right'); ShowHide('right_blocks_col_show'); ShowHide('right_blocks_col_hide');" title="Temporarily Hide Blocks"><img src="images/slide1.png" width="12" height="10" alt="" class="right_blocks_col_show" /></a>

Replace with:

Code: Select all

         <a href="javascript:ShowHide('right'); ShowHide('right_blocks_col_show'); ShowHide('right_blocks_col_hide');" title="{L_HIDE_BLOCKS_TEMP}"><img src="images/slide1.png" width="12" height="10" alt="" class="right_blocks_col_show" /></a>

Open:
../language/en/common.php (1 change)
Find:

Code: Select all

   'POST_BY_POSTER'            => 'by',

After add:

Code: Select all

   'HIDE_BLOCKS_TEMP'            => 'Temporarily Hide Blocks',
   'SHOW_BLOCKS'               => 'Show blocks',

This is change only for translators. English users will not see any effects

[Mike]

I have received the first report of problems from the phpBB devs... this included quite a few problems where I did not use lang variables... these are being fixed as we speak...

The vast majority, over 95% of problems found related to coding guidelines (mainly not using {} to block if(...) functions, and the language problems mentioned above...
As I said before, no more releases until all these are fixed... so forgive me for not being active everyday but I have a lot of files to clean up... Mike