Some Bugs after fresh install on 3.0.6

[WiZaRd]

Well, I wasn't talking about the .css code but the parts in the templates... there are no changes in 306-110 (and I'm still waiting for access for the newer versions) so the button isn't displayed, so I wanted to report that.
On a sidenote, even though it's neat to have all .css code in one file, it'd be better to use {THEME_PATH} for the url, don't you think?

On a sidenote: will the included and changed QR at some point include custom bbcodes, too?

[Mike]

To add a single language image in prosilver you are required to edits several files... plus of course the css file must be parsed, therefore it must be included with the @ option... As the portal css file is large, at least in relation to other css files, the database storage requirements are excessive for the job in hand...

The only advantage I can see from storing style information in the database in actually the parsing of paths... seems a lot of work for so little gain... anyway enough ranting... I will add some code so that the images paths can be written using variables in the near future...

On a sidenote: will the included and changed QR at some point include custom bbcodes, too?

There is provision for custom bbcodes already... I didn't take this any further after all the flack I got for adding the smilies and the basic bbcode... Seems you can't please people... I will look at the code and see what I can do...

Here are the edits for the viewtopics_body.html...
Find:

Code: Select all

<!-- IF S_QUICK_REPLY -->
   <!-- INCLUDE quickreply_editor.html -->
<!-- ENDIF -->

Replace with:

Code: Select all

<!-- IF S_QUICK_REPLY and not STARGATE -->
   <!-- INCLUDE quickreply_editor.html -->
<!-- ENDIF -->

we just add a switch so this code is not called if the portal is enabled... calls the normal editor...

We moved out version down the page a little (looks better)... Find:

Code: Select all

<!-- INCLUDE jumpbox.html -->

before add

Code: Select all

<!-- IF STARGATE and S_QUICK_REPLY and S_SGP_QUICK_REPLY -->
   <!-- INCLUDE sgp_quickreply_editor.html -->
<!-- ENDIF -->

You will note we call our own editor, as this allow us to reduce the number of edits to phpBB core files, which is our policy...
The attached files go into the portal common folder... I have included all I have but will consolidate these later (we only need four)...
If you find any of these files in the attachment in the style template folder they can be removed all except that is the default editor....

It would be a great deal easier if people had access to the SVN but I fear with all the ongoing edits people would pull their hair out as I keep changing things...
Once it's a bit more stable I will organise access...

[WiZaRd]

I finally got around to try your code...

Here are the edits for the viewtopics_body.html...
Find:

Code: Select all

<!-- IF S_QUICK_REPLY -->
   <!-- INCLUDE quickreply_editor.html -->
<!-- ENDIF -->

Replace with:

Code: Select all

<!-- IF S_QUICK_REPLY and not STARGATE -->
   <!-- INCLUDE quickreply_editor.html -->
<!-- ENDIF -->

we just add a switch so this code is not called if the portal is enabled... calls the normal editor...

Wouldn't it be better to also check for S_SGP_QUICK_REPLY here?

Finally, I included your changes but I get a template error (sgp_quick_reply.html) which seems to be missing in 306-110... so I have to wait for the next releases/SVN access

[Mike]

My fault... the update is actually for 307-001/002... but could be added to 110, of course we need another edit...
It's probably best to wait for 307-002 as it contains all updates..

Main 307-002 updates are:
Allows access to phpBB common data (normally processed in the function header code), which reduces query count...
Greatly reduces the size of several blocks... (by wrapping core functions to prevent redeclaration)...
Allows you to pass meta data and basic variables to your web pages...

meta_data.png (3.79 KiB) Viewed 129 times

In progress:
Adds a simple editor to ACP for minimods... Later we will add it to any module that allows editing such as the web pages mod.

minimod_basic_editor.png (25.68 KiB)

minimod_basic_editor.png (25.68 KiB) Viewed 130 times

[WiZaRd]

Sounds very good

[WiZaRd]

I just came across another issue:
When adjusting the "Link to us" parameters, the cache isn't cleared. Also, the image is described as
Enter the image name. Located in: (./images/links/) (size: 88x31px)
but that doesn't work, it will only insert img src=<imagename> in the link to us box, so one has to insert the COMPLETE link there. Additionally, it's not good to put the banner into ./images/links because it will then also be added to the "links" box, automatically.

[Mike]

Will fix for 307-102
You only require the image name... The image is parsed in the link to us block...

Code: Select all

    'U_SITE_LINK_IMG'            =>  '<a href="' . $url . '/portal.php">' . '<img src="' . $phpbb_root_path . 'images/' . $site_ref_img . '" alt="" /></a>',

You can add height/width if you want...

I have moved the location to ./images and altered the wording to:

Code: Select all

   'LINK_TO_US' => 'The link image name',
   'LINK_TO_US_EXPLAIN' => 'The image must exist in: ./images folder. (size: 88x31px)',